Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37829 )
Change subject: asus/am1i-a: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 1:
(1 comment)
By the way, it was surprisingly easy to switch away from ROMCC_BOOTBLOCK, and booted fine at the first attempt! I wonder if this approach could be done for the other AMD boards even without testing (if no one could test at the moment).
https://review.coreboot.org/c/coreboot/+/37829/1/src/mainboard/asus/am1i-a/b... File src/mainboard/asus/am1i-a/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37829/1/src/mainboard/asus/am1i-a/b... PS1, Line 125: /* Disable PCI-PCI bridge and release GPIO32/33 for other uses. */
Can you check datasheet if this is valid for fam16kb.
I checked https://www.amd.com/system/files/TechDocs/48751_16h_bkdg.pdf page 859 - and there is no 0xEA, only 0xE8 and 0xEB; either this is undocumented or no such a register. Also I couldn't find another PM register providing this functionality, and to be honest - don't know where this code came from (it has been there since the initial commit), why it's disabling this PCI bridge or why GPIO32/33 could be needed for other uses. A bit later I could try building without it.