Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38988 )
Change subject: mainboard: Add new board ASUS P8Z77-M ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38988/11/src/mainboard/asus/p8z77-m... File src/mainboard/asus/p8z77-m/cmos.layout:
https://review.coreboot.org/c/coreboot/+/38988/11/src/mainboard/asus/p8z77-m... PS11, Line 98: # gfx_uma_size (Intel IGP Video RAM size) : 7 0 32M : 7 1 64M : 7 2 96M : 7 3 128M : 7 4 160M : 7 5 192M : 7 6 224M : 7 7 256M : 7 8 288M : 7 9 320M : 7 10 352M : 7 11 384M : 7 12 416M : 7 13 448M : 7 14 480M : 7 15 512M : 7 16 544M : 7 17 576M : 7 18 608M : 7 19 640M : 7 20 672M : 7 21 704M : 7 22 736M : 7 23 768M : 7 24 800M : 7 25 832M : 7 26 864M : 7 27 896M : 7 28 928M : 7 29 960M : 7 30 992M
Intel's doc are hard to believe, with a substantial typo on the same page. […]
Vendor EFI should have an option to choose the stolen graphics memory size, from what I can see it's the same encoding as in the datasheet.
https://review.coreboot.org/c/coreboot/+/38988/11/src/mainboard/asus/p8z77-m... File src/mainboard/asus/p8z77-m/early_init.c:
https://review.coreboot.org/c/coreboot/+/38988/11/src/mainboard/asus/p8z77-m... PS11, Line 89: /* This sequence enables early serial */ : SWITCH_TO, NCT6779D_SP1, : PNP_IDX_EN, 0, : PNP_IDX_IO0, CONFIG_TTYS0_BASE >> 8, : PNP_IDX_IO0 + 1, CONFIG_TTYS0_BASE & 0xff, : PNP_IDX_EN, 1,
See above. […]
Another option is to put it behind an `if (CONFIG(CONSOLE_SERIAL))` or similar, if not enabled it shouldn't even end up being compiled in