Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46605 )
Change subject: lib/libpayload: Replace strapping_ids with new board configuration entry
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46605/9/payloads/libpayload/libc/co...
File payloads/libpayload/libc/coreboot.c:
https://review.coreboot.org/c/coreboot/+/46605/9/payloads/libpayload/libc/co...
PS9, Line 283: info->sku_id = UNDEFINED_STRAPPING_ID;
nit: Also initialize fw_config here, so things would be sane if we leave out the entry?
Done
https://review.coreboot.org/c/coreboot/+/46605/9/src/lib/coreboot_table.c
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/46605/9/src/lib/coreboot_table.c@a2...
PS9, Line 222: if (bid == UNDEFINED_STRAPPING_ID)
Aah. That looks good. […]
Oops I missed that too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46605
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ecec847ee77b72233587c1ad7f124e2027470bf
Gerrit-Change-Number: 46605
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 27 Oct 2020 23:09:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment