Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37401 )
Change subject: mb/*/*: use ACPIMMIO common block wherever possible ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/hp/abm/romsta... File src/mainboard/hp/abm/romstage.c:
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/hp/abm/romsta... PS2, Line 45: pm_io_write8(0x24, 1); fam16kb using PMx24
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/msi/ms7721/ro... File src/mainboard/msi/ms7721/romstage.c:
https://review.coreboot.org/c/coreboot/+/37401/2/src/mainboard/msi/ms7721/ro... PS2, Line 139: pm_io_write8(0x24, 1); fam15tn using PMx24