13 Jan
2019
13 Jan
'19
5:58 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27089 )
Change subject: mb/asus/p5qpl-am: Add p5g41t-m_lx as a variant ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/27089/10/src/mainboard/asus/p5qpl-am/romstag... File src/mainboard/asus/p5qpl-am/romstage.c:
https://review.coreboot.org/#/c/27089/10/src/mainboard/asus/p5qpl-am/romstag... PS10, Line 76: old_reg = pnp_read_config(GPIO_DEV, 0x2c);
Even if repeated, I would prefer this next to the write of same register.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/27089
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92cd15a245c4f1d8f57b304c9c3a37ba29c35431
Gerrit-Change-Number: 27089
Gerrit-PatchSet: 11
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sun, 13 Jan 2019 17:58:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment