Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41895 )
Change subject: mb/google/volteer: Convert static ASL files to new DPTF implementation ......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41895/14/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41895/14/src/mainboard/google/volte... PS14, Line 282: ## Active Policy We need to add Weight parameter as well, which decides the priority between two sensors when they hit the threshold at the same time to avoid any kind of race conditions. This Weight works similar like priority between two sensors, reference as https://review.coreboot.org/c/coreboot/+/41895/14/src/mainboard/google/volte...
https://review.coreboot.org/c/coreboot/+/41895/14/src/mainboard/google/volte... PS14, Line 308: Passive Policy same as above active policy comment, we need Weight here as well to avoid any kind of race conditions between sensors. Previous asl code for reference, https://review.coreboot.org/c/coreboot/+/41895/14/src/mainboard/google/volte...
https://review.coreboot.org/c/coreboot/+/41895/14/src/mainboard/google/volte... PS14, Line 314: ## Critical Policy In Critical policy, once the sensor hits the temperature threshold, DPTF initiates the graceful system shutdown. I am not sure on SUSPEND srting below. Please, share details.