Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33808 )
Change subject: mb/google/hatch: Set GPP_D9 as enable pin for Goodix Touch Screen
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33808/2/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb:
https://review.coreboot.org/#/c/33808/2/src/mainboard/google/hatch/variants/...
PS2, Line 84: 3
if we set 1ms, the scope capture is under 1ms. so increase to 3. This is follow octopus setting.
Please update commit message to capture this change as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33808
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33140869990aa4715c780b0fa322921e450530ef
Gerrit-Change-Number: 33808
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 02 Jul 2019 15:54:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment