build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44720 )
Change subject: soc/mediatek/mt8192: Do dramc tx window training ......................................................................
Patch Set 1:
(24 comments)
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 1723: loop ++; space prohibited before that '++' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 1725: dramc_dbg("RWOFOEN timout! queue is not empty\n"); 'timout' may be misspelled - perhaps 'timeout'?
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2087: static void tx_win_transfer_delay_to_uipi(const struct ddr_cali* cali, u16 delay, "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2103: *p_pi =pi; spaces required around that '=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2111: tmp_val = (delay /pi_tap) << pi_to_ui; need consistent spacing around '/' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2116: tmp_val --; space prohibited before that '--' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2117: } else if (pi > pi_tap - 10) { please, no space before tabs
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2119: tmp_val ++; space prohibited before that '++' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2230: static void dramc_tx_set_vref(const struct ddr_cali* cali, u8 vref_range, u8 vref) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2237: static void tx_scan_range_PI(const struct ddr_cali* cali, tx_cali_type cali_type, "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2274: static void tx_scan_range_vref(const struct ddr_cali* cali, bool enable_vref_scan, "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2284: }else { space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2325: static void dramc_tx_window_perbit_cal_find_best_delay(const struct ddr_cali* cali, "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2405: if ((vref_win_perbit[bit].last_pass != Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2412: if (perbit_winsum > TX_PASS_WIN_CRITERIA) Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2448: static u16 dramc_tx_window_perbit_cal_find_best_vref(const struct ddr_cali* cali, "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2472: dramc_dbg("LP4 TX VrefRange %d, VrefLevel=%d\n", final_range, vref_level); line over 96 characters
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2489: dramc_tx_window_perbit_cal_find_best_delay(cali, cali_type,enable_vref_scan, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2527: dramc_dbg("TX Vref early break, caculate TX vref\n"); 'caculate' may be misspelled - perhaps 'calculate'?
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2555: void dramc_tx_window_perbit_cal(const struct ddr_cali* cali, "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2592: tx_scan_range_vref(cali, enable_vref_scan, &final_range, &vref_begin, &vref_end, &vref_step); line over 96 characters
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2615: final_vref = dramc_tx_window_perbit_cal_find_best_vref(cali, cali_type, enable_vref_scan, line over 96 characters
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2633: dramc_dbg("[TX_PER_BIT_DELAY_CELL] DelayCellTimex100 =%d/100 ps\n", params->delay_cell_timex100); line over 96 characters
https://review.coreboot.org/c/coreboot/+/44720/1/src/soc/mediatek/mt8192/dra... PS1, Line 2673: delay, dq_ui_large[byte], dq_ui_small[byte], dq_pi[byte], \ Avoid unnecessary line continuations