[coreboot-gerrit] Change in coreboot[master]: soc/intel: Replace uses of dev_find_slot()

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33996 )

Change subject: soc/intel: Replace uses of dev_find_slot()
......................................................................

Patch Set 4:
> Patch Set 4:
>
> This is uncovering much havoc it seems. There are reports of
> P2SB and MEI devices hidden from the tree. Both with KBL FSP,
> I'm not sure what makes the difference. If nobody has the time
> to look into it, I fear we should revert.
>
> I just had an idea how to work around the blob is hiding devices
> bugs. Add another setting for devicetree, beside `on`/`off` a
> `force` that marks the device as existing but potentially not
> probable. What do you think?

Since the device is hidden, to search for the node must be about accessing the devicetree configuration, not to do any pci_read/write_config (that would fail)?

First, we could modify PCI_BDF() macro to use __file__, __line__, that would make the error message useful and pinpoint location. Then, we could declare a wrapper to access dev->chip_info that also finds disconnected device configurations?

OR

Add Kconfig that allows for dev==NULL for pci_read/write_configX(), reads will return 0xFF and writes are being ignored.