Attention is currently required from: Angel Pons, Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian, Subrata Banik.
Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86336?usp=email )
Change subject: soc/intel/cmn/pmc: Add support for early power off ......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/common/block/pmc/Kconfig:
https://review.coreboot.org/c/coreboot/+/86336/comment/4e244b32_387f32ba?usp... : PS4, Line 93: When searching through the entire Coreboot project using grep, it appears that the convention is to use the `HAVE_` prefix. Should the term `HAVE_EARLY_POWEROFF_SUPPORT` be used to adhere to this convention?
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/86336/comment/f379f18b_df7632ab?usp... : PS4, Line 640: printk(BIOS_EMERG, "This platform doesn't know how to power off before ramstage," I believe that the "before ramstage" part is inaccurate. According to my earlier testing on Panther Lake, it also isn't working before FSP-S in ramstage. The exclamation point seems unnecessary. Could we use a message such as:
"This platform cannot be powered off until the silicon initialization is complete; entering an infinite loop."
Also, how does this code addresses the before FSP-S powering off in ramstage ?