Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47711 )
Change subject: cpu/x86/sipi_vector: Properly use uintptr_t
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47711/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47711/1//COMMIT_MSG@7
PS1, Line 7: Properly use uintptr_t
What does "properly" mean here? Instead, how about:
Use uintptr_t for memory addresses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47711
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc60e1efa6fe6a3029ef9e5e63ce50afa8c8c51c
Gerrit-Change-Number: 47711
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 18 Nov 2020 14:36:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment