Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36690 )
Change subject: cbfs: remove prepare() callback from struct cbfs_locator ......................................................................
Patch Set 1:
Patch Set 1:
The prepare mechanism is used by the eltan verified boot mechanism. So removing this completely would break that.
Didn't you guys already add prog_locate_hook() recently to do something similar? Could you maybe rewrite your vendorcode stuff to use that instead? It would be nice if we didn't need to maintain two hook mechanisms that are both only needed for a single platform when one of them is practically a superset of the other anyway.
(Also, since it looks like you're contributing directly to vboot and making it usable for your platform now, any chance we could drop your vendorcode solution and the associated hooks at some point?)
We will look at moving the prepare functionality to prog_locate_hook(). We will let you know if this works out in the next few days.