[coreboot-gerrit] Change in coreboot[master]: device/oprom: Lists all supported vesa mode by oprom

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34284 )

Change subject: device/oprom: Lists all supported vesa mode by oprom
......................................................................

Patch Set 2:

(2 comments)

general layout looks fine, but please don't return stack variables :-)

https://review.coreboot.org/c/coreboot/+/34284/2/src/device/oprom/realmode/x... 
File src/device/oprom/realmode/x86.c:

https://review.coreboot.org/c/coreboot/+/34284/2/src/device/oprom/realmode/x... 
PS2, Line 239: info
that's a stack variable...

https://review.coreboot.org/c/coreboot/+/34284/2/src/device/oprom/realmode/x... 
PS2, Line 248: info
... and here you return it right before tearing down that part of the stack.