Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29684 )
Change subject: soc/intel/common: Bring DISPLAY_MTRRS into the light ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/29684/3/src/cpu/Kconfig.debug File src/cpu/Kconfig.debug:
https://review.coreboot.org/#/c/29684/3/src/cpu/Kconfig.debug@1 PS3, Line 1: source "src/cpu/*/Kconfig.debug" nit: maybe just put this line directly into src/Kconfig?
https://review.coreboot.org/#/c/29684/3/src/cpu/x86/Kconfig.debug File src/cpu/x86/Kconfig.debug:
https://review.coreboot.org/#/c/29684/3/src/cpu/x86/Kconfig.debug@1 PS3, Line 1: config HAVE_DISPLAY_MTRRS Shouldn't this whole file have an if ARCH_X86 wrapped around it? (Then again, I'm asking myself the same thing about src/cpu/x86/Kconfig... and why *is* there an if ARCH_X86 with a bunch of x86-specific crap in src/cpu/Kconfig?)