Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48423 )
Change subject: soc/intel/common: Check sizes of CSE CBFS RW blob and CSE RW BP
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48423/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/48423/3/src/soc/intel/common/block/...
PS3, Line 680: if (region_device_sz(target_rdev) < cse_blob_sz)
It would be helpful to have an error print in this case indicating the sizes: […]
Ack
https://review.coreboot.org/c/coreboot/+/48423/3/src/soc/intel/common/block/...
PS3, Line 681: CSE_LITE_SKU_LAYOUT_MISMATCH_ERROR
I would really like to catch this error at build time instead of waiting until runtime to know that […]
I have raised crosbug(B:175304872) to track the changes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48423
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8be589eae905b1a54a8cf981ccd3a00bd5e733f5
Gerrit-Change-Number: 48423
Gerrit-PatchSet: 4
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Dec 2020 21:13:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment