Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45345 )
Change subject: soc/intel/common/block: Move PRMRR options to CPU subfolder ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45345/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45345/2//COMMIT_MSG@12 PS2, Line 12: C6DRAM
well, but then it's only SGX in cb again... […]
If there's a C6DRAM enable switch that can be used in Kconfig, then we can use it here to hide PRMRR settings if C6DRAM is enabled.
https://review.coreboot.org/c/coreboot/+/45345/2/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/45345/2/src/soc/intel/common/block/... PS2, Line 106: prompt "PRMRR size"
Oh, I overlooked that... […]
If we don't, then the symbols are not defined, and the code in cpulib.c can go haywire (like it did). If FSP overrides PRMRR settings when C6DRAM is enabled, then we should hide this when C6DRAM is enabled.