build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35227 )
Change subject: src/soc/intel/common/block/cse: Add funtion to send CSE reset msg ......................................................................
Patch Set 1:
(51 comments)
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 612: int status; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 613: struct reset_reply { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 614: u8 group_id; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 614: u8 group_id; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 615: u8 command; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 615: u8 command; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 616: u8 reserved; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 616: u8 reserved; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 617: u8 result; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 617: u8 result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 618: } __packed reply; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 619: struct reset_message { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 620: u8 group_id; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 620: u8 group_id; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 621: u8 cmd; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 621: u8 cmd; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 622: u8 reserved; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 622: u8 reserved; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 623: u8 result; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 623: u8 result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 624: u8 req_origin; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 624: u8 req_origin; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 625: u8 reset_type; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 625: u8 reset_type; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 626: } __packed; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 627: struct reset_message msg = { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 628: .group_id = MKHI_GROUP_ID_CBM, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 628: .group_id = MKHI_GROUP_ID_CBM, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 629: .cmd = MKHI_GLOBAL_RESET_REQ, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 629: .cmd = MKHI_GLOBAL_RESET_REQ, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 630: .req_origin = GR_ORIGIN_BIOS_POST, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 630: .req_origin = GR_ORIGIN_BIOS_POST, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 631: .reset_type = rst_type code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 631: .reset_type = rst_type please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 632: }; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 633: size_t reply_size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 635: if (!((rst_type == GLOBAL_RESET) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 635: if (!((rst_type == GLOBAL_RESET) suspect code indent for conditional statements (7, 15)
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 638: return -1; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 639: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 641: heci_reset(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 643: reply_size = sizeof(reply); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 644: memset(&reply, 0, reply_size); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 646: printk(BIOS_ERR, "HECI Global Reset(type=%d) Command\n", rst_type); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 647: status = heci_send_receive(&msg, sizeof(msg), &reply, &reply_size); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 648: if (status != 1) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 648: if (status != 1) suspect code indent for conditional statements (7, 14)
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 649: return -1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 649: return -1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 651: printk(BIOS_DEBUG, "HECI GBL RST success!\n"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35227/1/src/soc/intel/common/block/... PS1, Line 652: return 0; please, no spaces at the start of a line