HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39613 )
Change subject: sc7180: Add display 10nm phy & pll programming support ......................................................................
Patch Set 23:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39613/23/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display/dsi_phy.c:
https://review.coreboot.org/c/coreboot/+/39613/23/src/soc/qualcomm/sc7180/di... PS23, Line 22: S_DIV_ROUND_UP src/commonlib/bsd/include/commonlib/bsd/helpers.h ?
https://review.coreboot.org/c/coreboot/+/39613/23/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display/dsi_phy_pll.c:
https://review.coreboot.org/c/coreboot/+/39613/23/src/soc/qualcomm/sc7180/di... PS23, Line 22: uint32_t <stdint.h> ?
https://review.coreboot.org/c/coreboot/+/39613/23/src/soc/qualcomm/sc7180/in... File src/soc/qualcomm/sc7180/include/soc/display/display_resources.h:
https://review.coreboot.org/c/coreboot/+/39613/23/src/soc/qualcomm/sc7180/in... PS23, Line 13: uint32_t <stdint.h>
https://review.coreboot.org/c/coreboot/+/39613/23/src/soc/qualcomm/sc7180/in... File src/soc/qualcomm/sc7180/include/soc/display/dsi_phy.h:
https://review.coreboot.org/c/coreboot/+/39613/23/src/soc/qualcomm/sc7180/in... PS23, Line 18: uint32_t <stdint.h> ?
https://review.coreboot.org/c/coreboot/+/39613/23/src/soc/qualcomm/sc7180/in... File src/soc/qualcomm/sc7180/include/soc/display/dsi_phy_pll.h:
https://review.coreboot.org/c/coreboot/+/39613/23/src/soc/qualcomm/sc7180/in... PS23, Line 32: s64 <stdint.h> ?