Attention is currently required from: Johnny Lin, Subrata Banik.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55745 )
Change subject: util/ifdtool: Add Cooper Lake platform support under IFDv2
......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS3:
yes +2 for patchset 1 and if you can split the patch into 2 CL ?
Why? Some things would be wrong for CPX in patchset 1 if things are split up.
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/55745/comment/25dd7aba_39a86564
PS3, Line 796: %s Region Write Access: %s\n",
: region_names[8].pretty,
Not needed.
https://review.coreboot.org/c/coreboot/+/55745/comment/5f8d0389_006d64d2
PS3, Line 812: %s Region Read Access: %s\n",
: region_names[8].pretty,
also not needed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55745
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I444e7d35a85d9d42fc25d654e57386f38cf1ec85
Gerrit-Change-Number: 55745
Gerrit-PatchSet: 3
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Wed, 23 Jun 2021 08:25:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment