Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38620 )
Change subject: mb/google/volteer: add volteer mainboard initial support
......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38620/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38620/7//COMMIT_MSG@8
PS7, Line 8:
Created what way or copied from where?
Done
https://review.coreboot.org/c/coreboot/+/38620/7/src/mainboard/google/voltee...
File src/mainboard/google/volteer/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/38620/7/src/mainboard/google/voltee...
PS7, Line 1: /* Nothing here */
delete this file
Done
https://review.coreboot.org/c/coreboot/+/38620/7/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/38620/7/src/mainboard/google/voltee...
PS7, Line 20: stdint.h
<stddef. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38620
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03a13f3df4e819ab9cf63ad69867c807d2a1b651
Gerrit-Change-Number: 38620
Gerrit-PatchSet: 8
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Jan 2020 23:37:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment