Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35110 )
Change subject: soc/mediatek/mt8183: Run DRAM full calibration ......................................................................
Patch Set 52:
(8 comments)
https://review.coreboot.org/c/coreboot/+/35110/50/src/mainboard/google/kukui... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/50/src/mainboard/google/kukui... PS50, Line 48: assert(length <= CALIBRATION_REGION_SIZE);
this is no longer needed since we have the _Static_assert.
Done
https://review.coreboot.org/c/coreboot/+/35110/50/src/mainboard/google/kukui... PS50, Line 64: .get_sdram_config = &get_sdram_config,
hmmm, given that this is already defined in soc/sdram_configs. […]
Done
https://review.coreboot.org/c/coreboot/+/35110/50/src/soc/mediatek/mt8183/me... File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/35110/50/src/soc/mediatek/mt8183/me... PS50, Line 56: ", header->magic
header. […]
Done
https://review.coreboot.org/c/coreboot/+/35110/50/src/soc/mediatek/mt8183/me... PS50, Line 57: version
print expected version as well
Done
https://review.coreboot.org/c/coreboot/+/35110/50/src/soc/mediatek/mt8183/me... PS50, Line 58: .siz
print expected size as well
Done
https://review.coreboot.org/c/coreboot/+/35110/50/src/soc/mediatek/mt8183/me... PS50, Line 68: BIOS_NOTICE
BIOS_WARNING
Done
https://review.coreboot.org/c/coreboot/+/35110/50/src/soc/mediatek/mt8183/me... PS50, Line 75: BIOS_NOTICE
BIOS_WARNING
Done
https://review.coreboot.org/c/coreboot/+/35110/50/src/soc/mediatek/mt8183/me... PS50, Line 107: |
&
Done