Attention is currently required from: Jayvik Desai, Pranava Y N, Subrata Banik.
Kapil Porwal has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87092?usp=email )
Change subject: commonlib/storage: Include pci_def.h
......................................................................
Patch Set 2:
(1 comment)
File src/commonlib/storage/pci_sdhci.c:
https://review.coreboot.org/c/coreboot/+/87092/comment/dfc95ad3_d74fda4d?usp... :
PS2, Line 5: #include <device/pci_def.h>
This is already part of above header when CONFIG_PCI is enabled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87092?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5c70d9b9ebcac13b47bba2c260fdf2ad7d56d4d7
Gerrit-Change-Number: 87092
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 02 Apr 2025 15:36:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No