Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32533 )
Change subject: sb/{ICH7,NM10,PCH}: Use common watchdog_off function
......................................................................
Patch Set 8: Code-Review+1
(3 comments)
https://review.coreboot.org/#/c/32533/8/src/southbridge/intel/common/tco.h
File src/southbridge/intel/common/tco.h:
https://review.coreboot.org/#/c/32533/8/src/southbridge/intel/common/tco.h@3
PS8, Line 3: *
Missing Copyright
https://review.coreboot.org/#/c/32533/8/src/southbridge/intel/common/watchdo...
File src/southbridge/intel/common/watchdog.c:
https://review.coreboot.org/#/c/32533/8/src/southbridge/intel/common/watchdo...
PS8, Line 18: <arch/io.h>
Why do you need arch/io.h?
https://review.coreboot.org/#/c/32533/8/src/southbridge/intel/common/watchdo...
PS8, Line 52: <<
Use define instead of magic value
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32533
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I704780b6ae7238560dcb72fc027addc1089e0674
Gerrit-Change-Number: 32533
Gerrit-PatchSet: 8
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Guckian
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 03 May 2019 15:55:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment