build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52878 )
Change subject: mb/google/octopus: add audio codec into SSFC support for Phaser ......................................................................
Patch Set 1:
(4 comments)
File src/mainboard/google/octopus/variants/phaser/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118335): https://review.coreboot.org/c/coreboot/+/52878/comment/ccc745a3_7442ecfe PS1, Line 17: PAD_CFG_GPI_APIC_IOS(GPIO_137, NONE, DEEP,LEVEL, INVERT, HIZCRx1, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118335): https://review.coreboot.org/c/coreboot/+/52878/comment/c0735e15_8b513402 PS1, Line 18: DISPUPD), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118335): https://review.coreboot.org/c/coreboot/+/52878/comment/8c63fca3_ebcd5a30 PS1, Line 40: PAD_CFG_GPI_APIC_IOS(GPIO_137,NONE, DEEP, LEVEL, INVERT, HIZCRx1, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118335): https://review.coreboot.org/c/coreboot/+/52878/comment/35c1764d_37c29d1d PS1, Line 41: DISPUPD), code indent should use tabs where possible