12 Jan
2021
12 Jan
'21
5:57 a.m.
Attention is currently required from: Jason Glenesk, Marshall Dawson, Kyösti Mälkki, Felix Held. Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48718 )
Change subject: ACPI: Add common acpi_fill_gnvs() ......................................................................
Patch Set 7:
(1 comment)
File src/acpi/gnvs.c:
https://review.coreboot.org/c/coreboot/+/48718/comment/09a327e0_3707dd46 PS7, Line 83: gnvs who set the gnvs here? What about the soc they don't have gnvs at all?
--
To view, visit https://review.coreboot.org/c/coreboot/+/48718
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I515e830808a95eee3ce72b16fd26da6ec79dac85
Gerrit-Change-Number: 48718
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Mariusz Szafrański mariuszx.szafranski@intel.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michal Motyl michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Suresh Bellampalli suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 12 Jan 2021 13:57:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment