Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Mathew King, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51503 )
Change subject: [RFC] soc/amd/common: Add IRQ routing config to common config ......................................................................
Patch Set 6:
(4 comments)
File src/soc/amd/cezanne/fch.c:
https://review.coreboot.org/c/coreboot/+/51503/comment/17547007_a489d6a9 PS6, Line 74: if (cfg->irq_routing[index].valid) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/51503/comment/8f7b6e1c_34e02505 PS6, Line 84: if (cfg->irq_routing[index].valid) { braces {} are not necessary for single statement blocks
File src/soc/amd/picasso/fch.c:
https://review.coreboot.org/c/coreboot/+/51503/comment/861dd056_715db192 PS6, Line 91: if (cfg->irq_routing[index].valid) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/51503/comment/53592195_37724a8d PS6, Line 101: if (cfg->irq_routing[index].valid) { braces {} are not necessary for single statement blocks