Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39370 )
Change subject: src/soc/intel: Add support for PMC core driver
......................................................................
Patch Set 6:
(2 comments)
This should be two commits.
https://review.coreboot.org/c/coreboot/+/39370/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39370/6//COMMIT_MSG@7
PS6, Line 7: src/soc/intel: Add support for PMC core driver
soc/intel/common: Add ACPI support for PMC OS core driver
What is a “core” driver?
https://review.coreboot.org/c/coreboot/+/39370/6//COMMIT_MSG@10
PS6, Line 10:
The Tiger Lake change is not mentioned. Please split it out.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39370
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4edc7b636725177d508b62d15633534e9f44236
Gerrit-Change-Number: 39370
Gerrit-PatchSet: 6
Gerrit-Owner: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 16 Mar 2020 07:33:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment