[coreboot-gerrit] Change in ...coreboot[master]: ec/google/wilco: Add virtual button support

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31208 )

Change subject: ec/google/wilco: Add virtual button support
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/31208/4/src/ec/google/wilco/acpi/event.asl 
File src/ec/google/wilco/acpi/event.asl:

https://review.coreboot.org/#/c/31208/4/src/ec/google/wilco/acpi/event.asl@8... 
PS4, Line 85: If (EBIT (E2OR, Arg0)) {
> Does this work with the OEM's tristate enum for orientations that they want to use? Or will this pot […]

No I ignored the other bit as it wouldn't fit in to how Chrome handles these modes.  If needed we can add the rotate lock virtual button later, but there will need to be work at a lot of other layers first for it to do anything useful.

https://review.coreboot.org/#/c/31208/4/src/ec/google/wilco/acpi/event.asl@9... 
PS4, Line 91: Y
> lowercase y?

Done