Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31464 )
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/31464/1/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/31464/1/src/drivers/intel/gma/Kconf... PS1, Line 72: COFFEE_LAKE
COFFEELAKE
Done
https://review.coreboot.org/c/coreboot/+/31464/1/src/drivers/intel/gma/Kconf... PS1, Line 73: WHISKEY_LAKE
WHISKEYLAKE
Done
https://review.coreboot.org/c/coreboot/+/31464/1/src/drivers/intel/gma/Kconf... PS1, Line 93: COFFEE_LAKE || SOC_INTEL_WHISKEY_LAKE
COFFEELAKE / WHISKEYLAKE
Done
https://review.coreboot.org/c/coreboot/+/31464/1/src/drivers/intel/gma/Kconf... PS1, Line 105: WHISKEY_LAKE
WHISKEYLAKE
Done
https://review.coreboot.org/c/coreboot/+/31464/2/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/31464/2/src/drivers/intel/gma/Kconf... PS2, Line 105: default "ULT" if (SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE) \ : && !SOC_INTEL_CANNONLAKE_PCH_H : default "ULT" if (SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE) && !SKYLAKE_SOC_PCH_H : default "ULT" if SOC_INTEL_BROADWELL || NORTHBRIDGE_INTEL_HASWELL :
the lint checker did not seem to be able to handle nested parentheses so I split this into separate […]
Gone