Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44669 )
Change subject: tests: Add lib/imd-test test case
......................................................................
Patch Set 3:
For all of the comments (against patchset 2) that you have resolved, please mark them as resolved. As long as there are unresolved comments, your CL cannot be submitted.
Buildbot is complaining about line length; this is because we use tab characters (linux style) and they are treated as 8 spaces side. Please fix the line lengths as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44669
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d3ab45c3da2a21c910f52a84526b60c39ff1fe7
Gerrit-Change-Number: 44669
Gerrit-PatchSet: 3
Gerrit-Owner: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Anna Karaś
aka@semihalf.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 08 Oct 2020 15:47:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment