Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41272 )
Change subject: soc/amd/common/block: Add support for configuring eSPI connection to slave ......................................................................
Patch Set 4: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/41272/4/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/espi.h:
https://review.coreboot.org/c/coreboot/+/41272/4/src/soc/amd/common/block/in... PS4, Line 65: VAL Ah, forgot to call this one out too.
https://review.coreboot.org/c/coreboot/+/41272/2/src/soc/amd/common/block/lp... File src/soc/amd/common/block/lpc/espi_util.c:
https://review.coreboot.org/c/coreboot/+/41272/2/src/soc/amd/common/block/lp... PS2, Line 763: enabled
The channels are reset by eSPI RESET# which is the first thing that espi_setup() does. […]
Ah good point.