3 Nov
2023
3 Nov
'23
6:14 p.m.
Attention is currently required from: Angel Pons, Christian Walter, Felix Singer, Martin L Roth, Maximilian Brune, Patrick Georgi, Paul Menzel, Subrata Banik, Werner Zeh, ron minnich.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74124?usp=email )
Change subject: Add support for rust ......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Patchset:
PS1: - Assumes rustup is installed by some means, with no explanation on how it is installed - Hard-codes the Rust version in the rustup command instead of specifying a toolchain override - Installs arbitrary tools, with no explanation of why they are required
--
To view, visit https://review.coreboot.org/c/coreboot/+/74124?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibff3ca83b3dfebcc18006cddf0f649bcfb076500
Gerrit-Change-Number: 74124
Gerrit-PatchSet: 1
Gerrit-Owner: ron minnich rminnich@gmail.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: Patrick Georgi patrick@coreboot.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Crawford tcrawford@system76.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Patrick Georgi patrick@coreboot.org
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Werner Zeh werner.zeh@siemens.com
Gerrit-Attention: ron minnich rminnich@gmail.com
Gerrit-Comment-Date: Fri, 03 Nov 2023 17:14:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment