Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38252 ) Change subject: soc/intel/common/block/cpu/car: Enable caching before FSP-T ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/c/coreboot/+/38252/6/src/cpu/x86/16bit/entry16.i... File src/cpu/x86/16bit/entry16.inc: https://review.coreboot.org/c/coreboot/+/38252/6/src/cpu/x86/16bit/entry16.i... PS6, Line 134: #else
given that you just want to avoid setting 2 bits depending on the bootguard bit, how about the follo […] Small typo, should be: andl $(~0x60000000), %ebx
-- To view, visit https://review.coreboot.org/c/coreboot/+/38252 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1def754f7b0024725638fcea481fd3273ef3d24 Gerrit-Change-Number: 38252 Gerrit-PatchSet: 6 Gerrit-Owner: Gaggery Tsai <gaggery.tsai@intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan@intel.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai@intel.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Michael Niewöhner Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 06 Feb 2020 13:33:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz> Gerrit-MessageType: comment