Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47380 )
Change subject: mb/google/kukui: Add panel api after dsi start ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47380/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47380/4//COMMIT_MSG@9 PS4, Line 9: require requires
https://review.coreboot.org/c/coreboot/+/47380/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_anx7625.c:
https://review.coreboot.org/c/coreboot/+/47380/2/src/mainboard/google/kukui/... PS2, Line 45: struct edid *edid = &anx7625_data.edid;
Done
This is not done.
https://review.coreboot.org/c/coreboot/+/47380/4/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_anx7625.c:
https://review.coreboot.org/c/coreboot/+/47380/4/src/mainboard/google/kukui/... PS4, Line 47: i2c_bus Simply "ANX7625_I2C_BUS" and remove the local variable.
https://review.coreboot.org/c/coreboot/+/47380/4/src/mainboard/google/kukui/... PS4, Line 62: u8 const u8