Thejaswani Putta has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35141 )
Change subject: mb/google/drallion: Add memory init setup for drallion
......................................................................
Patch Set 19:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35141/19/src/mainboard/google/drall...
File src/mainboard/google/drallion/romstage.c:
https://review.coreboot.org/c/coreboot/+/35141/19/src/mainboard/google/drall...
PS19, Line 62: int mem_sku;
You should guard this section or it will overwrite the sarien/arcada setting. […]
Yes, Agreed. I need to rebase my patch on top of Bernardo's - mb/google/drallion: Enable 360 sensor detection patch. Will update now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9993ad175e6f52711d5a05733aeab1bbed1e0b80
Gerrit-Change-Number: 35141
Gerrit-PatchSet: 19
Gerrit-Owner: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aamir Bohra
aamir.bohra@intel.com
Gerrit-CC: AndreX Andraos
andrex.andraos@intel.com
Gerrit-CC: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Chiranjeevi Rapolu
chiranjeevi.rapolu@intel.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Krzysztof M Sywula
krzysztof.m.sywula@intel.com
Gerrit-CC: Mathew King
mathewk@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.com
Gerrit-CC: Varun Joshi
varun.joshi@intel.com
Gerrit-Comment-Date: Mon, 16 Sep 2019 18:25:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment