Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37282 )
Change subject: soc/intel/common: Rename functions to have consistency naming
......................................................................
Patch Set 15:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37282/15//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37282/15//COMMIT_MSG@7
PS15, Line 7: to have consistency naming
for consistent naming
https://review.coreboot.org/c/coreboot/+/37282/15//COMMIT_MSG@10
PS15, Line 10: consistency
consistent
https://review.coreboot.org/c/coreboot/+/37282/15/src/soc/intel/common/block...
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/37282/15/src/soc/intel/common/block...
PS15, Line 257: 15
HECI_DELAY
https://review.coreboot.org/c/coreboot/+/37282/15/src/soc/intel/common/block...
PS15, Line 261: printk(BIOS_ERR, "HECI: Timed out!\n");
I know it’s in the above message already, but if only error level debugging is used, please also add HECI_DELAY here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37282
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfcf1631cc37faacdea9ad84be55f5710104bad5
Gerrit-Change-Number: 37282
Gerrit-PatchSet: 15
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 16 Jan 2020 14:30:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment