Attention is currently required from: Furquan Shaikh, Subrata Banik, Kyösti Mälkki, Patrick Rudolph.
Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50297 )
Change subject: soc/intel: Drop CID1 from GNVS
......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/common/block/acpi/acpi/globalnvs.asl:
https://review.coreboot.org/c/coreboot/+/50297/comment/aa1544e9_76ab8759
PS2, Line 23: , 16, // 0x29 - 0x2a Wifi Country Identifier
If we totally drop it, why not delete here as well?
File src/soc/intel/common/block/include/intelblocks/nvs.h:
https://review.coreboot.org/c/coreboot/+/50297/comment/2047020e_37685b2c
PS2, Line 23: unused_was_cid1
Why not totally drop it if removed everywhere?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50297
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09ea756fb3743e33d1e221f0a0df3a6fdc3fc3ba
Gerrit-Change-Number: 50297
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 07 Feb 2021 16:38:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
