Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46967 )
Change subject: soc/intel/broadwell: Improve LPD0/LPD3 SerialIO ACPI methods
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46967/1/src/soc/intel/broadwell/pch...
File src/soc/intel/broadwell/pch/acpi/serialio.asl:
https://review.coreboot.org/c/coreboot/+/46967/1/src/soc/intel/broadwell/pch...
PS1, Line 9: 0x84
Is there a better name for this register?
Reference code ACPI and BIOS spec do not give it any name. Reference code has a PME_CTRL_STS macro, and EDS calls it PME_CTRL_STA. I doubt using either name would be an improvement.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46967
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88272fc5cbe35427ccb5fc50789d47b66ace88fe
Gerrit-Change-Number: 46967
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 29 Oct 2020 16:46:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment