Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39852 )
Change subject: mb/google/dedede: Add weak pull-up for EC_AP_PWR_BTN_ODL gpio
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39852/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39852/1//COMMIT_MSG@13
PS1, Line 13: Boot the mainboard.
Not yet. The SoC went from G3 to S0 with the change. […]
Okay. I think this change is still needed independent of that issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39852
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I042ba70f78fca1a5b9eda30029df97b3f8e65656
Gerrit-Change-Number: 39852
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 06 Apr 2020 19:22:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment