Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45288 )
Change subject: amdfwtool: Apply the change of config file to hudson ......................................................................
Patch Set 13:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45288/13/src/southbridge/amd/pi/hud... File src/southbridge/amd/pi/hudson/Kconfig:
https://review.coreboot.org/c/coreboot/+/45288/13/src/southbridge/amd/pi/hud... PS13, Line 66: config AMDFW_CONFIG_FILE bolton doesn't need the additional things avalon needs, right? what about kern?
https://review.coreboot.org/c/coreboot/+/45288/13/src/southbridge/amd/pi/hud... File src/southbridge/amd/pi/hudson/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45288/13/src/southbridge/amd/pi/hud... PS13, Line 95: SMUFIRMWARE2_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware2_prod_CZ.sbin this isn't used any more, so remove. there are probably some more things that can be removed due to being unused after this change
https://review.coreboot.org/c/coreboot/+/45288/13/src/southbridge/amd/pi/hud... PS13, Line 100: #SMUFWM_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware$(FIRMWARE_TYPE).sbin : #SMUFWM_FN_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware$(FIRMWARE_TYPE)_FN.sbin : #SMUSCS_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuScs$(FIRMWARE_TYPE).bin please remove instead of commenting out