Attention is currently required from: Máté Kukri, Maxim Polyakov, Tristan Corrick, Angel Pons, Arthur Heymans. Iru Cai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30890 ) Change subject: autoport: Add support for Haswell-LynxPoint platform ...................................................................... Patch Set 34: (3 comments) Patchset: PS34: Uploaded a new version for the devicetree change. File util/autoport/bd82x6x.go: https://review.coreboot.org/c/coreboot/+/30890/comment/e18c0739_70965518 PS32, Line 13: func writeGPIOSet(ctx Context, sb *os.File,
Ping Done
File util/autoport/lynxpoint.go: https://review.coreboot.org/c/coreboot/+/30890/comment/6a0f0d0f_dfa189c2 PS32, Line 170: uint16(0x100+g*8)]
or make functions to encapsulate the `inteltool.GPIO[uint16(... […] Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/30890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f6e8c97b5122101de2f36bba8ba9f8ddd5b813a Gerrit-Change-Number: 30890 Gerrit-PatchSet: 34 Gerrit-Owner: Iru Cai <mytbk920423@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Daniel Maslowski <info@orangecms.org> Gerrit-Reviewer: Iru Cai <mytbk920423@gmail.com> Gerrit-Reviewer: Jamal Wright <Crabstorage@getbackinthe.kitchen> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com> Gerrit-Reviewer: Pablo Stebler <pablo@stebler.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-CC: Christoph Pomaska <github@slrie.de> Gerrit-CC: Máté Kukri <kukri.mate@gmail.com> Gerrit-CC: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Attention: Máté Kukri <kukri.mate@gmail.com> Gerrit-Attention: Maxim Polyakov <max.senia.poliak@gmail.com> Gerrit-Attention: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Comment-Date: Sat, 11 Feb 2023 14:13:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maxim Polyakov <max.senia.poliak@gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment