Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Naresh Solanki, Varshit Pandya.
Felix Held has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/87124?usp=email )
Change subject: soc/amd/*/include/soc/msr.h: Move MSR to common location
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/soc/amd/phoenix/include/soc/msr.h:
https://review.coreboot.org/c/coreboot/+/87124/comment/5863a798_3a51b6fe?usp... :
PS1, Line 8: #include<cpu/amd/msr.h>
space missing before the '<'; also same for the other socs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87124?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic0cb54b13320f8a38e70c0a76d9b9a51ba0ea01d
Gerrit-Change-Number: 87124
Gerrit-PatchSet: 1
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Comment-Date: Wed, 02 Apr 2025 20:28:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes