Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46093 )
Change subject: soc/intel/xeon_sp: Move function debug macros
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46093/5/src/include/device/device.h
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/46093/5/src/include/device/device.h...
PS5, Line 282: #if CONFIG(DEBUG_FUNC)
This was from Angels comment: https://review.coreboot. […]
Sorry for going back and forth so much... I don't think the scope of these macros should be extended. If one really needs to trace function entry/exit often, it may be a good idea to clean up the code flow to improve readability.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46093
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie237bdf8cdc42c76f38a0c820fdc92e81095f47c
Gerrit-Change-Number: 46093
Gerrit-PatchSet: 5
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 22 Oct 2020 17:00:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-MessageType: comment