Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48742 )
Change subject: security/tpm: Add crypto agility support ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/48742/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48742/1//COMMIT_MSG@10 PS1, Line 10: * Added TPM2 tlcl_extend crypto agility TESTED=On Facebook Watson_V2 mainboard, the TCPA log now shows correct hash content and algorithm: PCR-0 62571891215b4efc1ceab744ce59dd0b66ea6f73 SHA1 [VBOOT: boot mode] instead of: PCR-0 62571891215b4efc1ceab744ce59dd0b66ea6f73 SHA256 [VBOOT: boot mode]
https://review.coreboot.org/c/coreboot/+/48742/1/src/security/tpm/tss/tcg-2.... File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/48742/1/src/security/tpm/tss/tcg-2.... PS1, Line 131: * sha256 digest. This comment needs to be updated. Caller also provides algorithm.