Jingle Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35367 )
Change subject: mb/ocp/monolake: Add a GPIO table for initializing configuration ......................................................................
Patch Set 2:
(3 comments)
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35367/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35367/1//COMMIT_MSG@9 PS1, Line 9: Add GPIO table for Monolake to initialize GPIOs.
why?
We simply want to have a gpio table that can be configured in a centrally managed way.
https://review.coreboot.org/c/coreboot/+/35367/1//COMMIT_MSG@10 PS1, Line 10: Tested on Monolake
how?
Verified by using ITP to check the configurations
https://review.coreboot.org/c/coreboot/+/35367/1/src/mainboard/ocp/monolake/... File src/mainboard/ocp/monolake/romstage.c:
https://review.coreboot.org/c/coreboot/+/35367/1/src/mainboard/ocp/monolake/... PS1, Line 66: init_gpios(gpio_tables);
why here and not in ramstage or early_romstage?
We initialize GPIOs when fsp setup_gpio_io_address() finished, which is after early_romstage.