Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29423 )
Change subject: soc/intel/braswell: Configure IO APIC
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/29423/7/src/soc/intel/braswell/southcluster....
File src/soc/intel/braswell/southcluster.c:
https://review.coreboot.org/#/c/29423/7/src/soc/intel/braswell/southcluster....
PS7, Line 248: static void sc_enable_ioapic(struct device *dev)
The function is defined twice. Copy-paste error?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29423
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I917c30892b46ac1d964e7bab339082d17a1e706d
Gerrit-Change-Number: 29423
Gerrit-PatchSet: 7
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 Mar 2019 15:12:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment