Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51974 )
Change subject: security/intel/cbnt: Fix ibbhash command line ......................................................................
security/intel/cbnt: Fix ibbhash command line
Using brackets here seems to break the build for _some_ environments. Removing the brackets fixes it and works just fine.
Change-Id: I965b0356337fe74281e7f410fd2bf95c9d96ea93 Signed-off-by: Christian Walter christian.walter@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/51974 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Deomid "rojer" Ryabkov rojer9@fb.com Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/security/intel/cbnt/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved Deomid "rojer" Ryabkov: Looks good to me, but someone else must approve
diff --git a/src/security/intel/cbnt/Makefile.inc b/src/security/intel/cbnt/Makefile.inc index 788b1b7..0eea0a7 100644 --- a/src/security/intel/cbnt/Makefile.inc +++ b/src/security/intel/cbnt/Makefile.inc @@ -49,7 +49,7 @@ --pbet=$(CONFIG_INTEL_CBNT_PBET) \ --ibbflags=$(CONFIG_INTEL_CBNT_IBB_FLAGS) \ --entrypoint=$(shell printf "%d" 0xfffffff0) \ - --ibbhash={11,4,12} \ + --ibbhash=11,4,12 \ --ibbsegbase=$(call int-add, $(call int-subtract, 0xffffffff $(CONFIG_C_ENV_BOOTBLOCK_SIZE)) 1) \ --ibbsegsize=$(shell printf "%d" $(CONFIG_C_ENV_BOOTBLOCK_SIZE)) \ --ibbsegflag=0 \