[coreboot-gerrit] [M] Change in coreboot[main]: lib: Refactor ux_locales_get_text API

[Julius Werner (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tarun.

Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86283?usp=email )

Change subject: lib: Refactor ux_locales_get_text API
......................................................................

Patch Set 8:

(2 comments)

File src/include/ux_locales.h:

https://review.coreboot.org/c/coreboot/+/86283/comment/a994de87_53607b74?usp... :
PS5, Line 23: const char *ux_locales_get_text(const char *name, const char *fallback_text);
> > > Why should we still keep this API around? I think we should switch everything to using IDs. […]

Well, then change the test, of course. Tests do not have a purpose by themselves, they only exist to validate the underlying coreboot code. If the code changes, you can remove or rewrite the tests that checked cases which cannot exist anymore. If we now only have an API that takes an enum ID, the tests only need to check the behavior when passing those IDs (including edge cases like passing an illegal ID, or passing a valid ID but the resulting CBFS filename not existing).

File src/lib/ux_locales.c:

https://review.coreboot.org/c/coreboot/+/86283/comment/0b3cbe04_848034b0?usp... :
PS8, Line 27: ux_locale_text_msg
nit: should probably call this `ux_locale_fallback_text` to clarify that it is only used when the actual locale file cannot be found.