Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5436
-gerrit
commit 01e8ec0edef0d92dd4d8a44b561cd0a27b10ce47 Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Mon Mar 31 15:13:07 2014 +1100
superio/fintek/f71872: Avoid .c includes
Following the same reasoning as commit d304331 superio/fintek/f81865f: Avoid .c includes Clean up the early_serial #include directives in mainboard/romstage code.
Change-Id: Ia021229154dc90b830a314f3adc2a0dd444bd68d Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- src/superio/fintek/f71872/Makefile.inc | 1 + src/superio/fintek/f71872/chip.h | 2 +- src/superio/fintek/f71872/early_serial.c | 3 ++- src/superio/fintek/f71872/f71872.h | 4 +++- 4 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/superio/fintek/f71872/Makefile.inc b/src/superio/fintek/f71872/Makefile.inc index ed40eb0..58ba5d5 100644 --- a/src/superio/fintek/f71872/Makefile.inc +++ b/src/superio/fintek/f71872/Makefile.inc @@ -18,4 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ##
+romstage-$(CONFIG_SUPERIO_FINTEK_F71872) += early_serial.c ramstage-$(CONFIG_SUPERIO_FINTEK_F71872) += superio.c diff --git a/src/superio/fintek/f71872/chip.h b/src/superio/fintek/f71872/chip.h index a6ac51f..3368ef2 100644 --- a/src/superio/fintek/f71872/chip.h +++ b/src/superio/fintek/f71872/chip.h @@ -28,4 +28,4 @@ struct superio_fintek_f71872_config { struct pc_keyboard keyboard; };
-#endif +#endif /* SUPERIO_FINTEK_F71872_CHIP_H */ diff --git a/src/superio/fintek/f71872/early_serial.c b/src/superio/fintek/f71872/early_serial.c index af5cdb3..bbfc264 100644 --- a/src/superio/fintek/f71872/early_serial.c +++ b/src/superio/fintek/f71872/early_serial.c @@ -21,6 +21,7 @@ /* Pre-RAM driver for the Fintek F71872F/FG Super I/O chip. */
#include <arch/io.h> +#include <device/pnp.h> #include "f71872.h"
static void pnp_enter_conf_state(device_t dev) @@ -36,7 +37,7 @@ static void pnp_exit_conf_state(device_t dev) outb(0xaa, port); }
-static void f71872_enable_serial(device_t dev, u16 iobase) +void f71872_enable_serial(device_t dev, u16 iobase) { pnp_enter_conf_state(dev); pnp_set_logical_device(dev); diff --git a/src/superio/fintek/f71872/f71872.h b/src/superio/fintek/f71872/f71872.h index 585b142..577f8d1 100644 --- a/src/superio/fintek/f71872/f71872.h +++ b/src/superio/fintek/f71872/f71872.h @@ -32,4 +32,6 @@ #define F71872_VID 0x07 /* VID */ #define F71872_PM 0x0a /* ACPI/PME */
-#endif +void f71872_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_FINTEK_F71872_F71872_H */