HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44507 ) Change subject: soc/intel/apl: Add ACPI for SMBus control ...................................................................... Patch Set 12: (3 comments) https://review.coreboot.org/c/coreboot/+/44507/12/src/soc/intel/apollolake/a... File src/soc/intel/apollolake/acpi/smbus.asl: https://review.coreboot.org/c/coreboot/+/44507/12/src/soc/intel/apollolake/a... PS12, Line 65: Local1 = One : While ((Local1 == One)) Local1 = 1 While (Local1 == 1) https://review.coreboot.org/c/coreboot/+/44507/12/src/soc/intel/apollolake/a... PS12, Line 68: Local3 = (HSTS & 0x1E) Local3 = HSTS & 0x1E https://review.coreboot.org/c/coreboot/+/44507/12/src/soc/intel/apollolake/a... PS12, Line 69: If ((Local3 != Zero)) If (Local3 != 0) -- To view, visit https://review.coreboot.org/c/coreboot/+/44507 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3846266d3155bbe831123fef4751748ff0e00511 Gerrit-Change-Number: 44507 Gerrit-PatchSet: 12 Gerrit-Owner: Maxim Polyakov <max.senia.poliak@gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 02 Oct 2020 10:04:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment